Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backport): Remove os-dependent pieces of schema validation #2361

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(backport): Remove os-dependent pieces of schema validation #2361

merged 1 commit into from
Oct 25, 2023

Conversation

matthewfeickert
Copy link
Member

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Backport PR https://github.com/scikit-hep/pyhf/pull/2357
* Use pathlib to build the stem for the schema to use (version + type of schema).
   - c.f. https://github.com/python/cpython/issues/65238

@kratsg @matthewfeickert
fix(backport): Remove os-dependent pieces of schema validation
afc9fc2 
* Backport PR https://github.com/scikit-hep/pyhf/pull/ 2357
* Use pathlib to build the stem for the schema to use (version + type of schema).
   - c.f. python/cpython#65238
@matthewfeickert matthewfeickert added fix A bug fix backport Backport PRs from main to release branch labels Oct 25, 2023
@matthewfeickert matthewfeickert self-assigned this Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v0.7.x@9caaf1d). Click here to learn what that means.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/v0.7.x    #2361   +/-   ##
=================================================
  Coverage                  ?   98.21%           
=================================================
  Files                     ?       69           
  Lines                     ?     4543           
  Branches                  ?      803           
=================================================
  Hits                      ?     4462           
  Misses                    ?       47           
  Partials                  ?       34
Flag Coverage Δ
contrib 27.53% <0.00%> (?)
doctest 60.99% <0.00%> (?)
unittests-3.10 96.25% <0.00%> (?)
unittests-3.11 96.25% <0.00%> (?)
unittests-3.7 96.23% <0.00%> (?)
unittests-3.8 96.27% <0.00%> (?)
unittests-3.9 96.30% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 49ffa0c into release/v0.7.x Oct 25, 2023
18 checks passed
@matthewfeickert matthewfeickert deleted the backport/windows-fix branch October 25, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
backport Backport PRs from main to release branch fix A bug fix
Projects
pyhf v0.7.5
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewfeickert @kratsg